Skip to content

gui: leader schedule + peer vote info #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gui: leader schedule + peer vote info #6610

wants to merge 1 commit into from

Conversation

jherrera-jump
Copy link
Contributor

No description provided.

@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch 2 times, most recently from 2abfe85 to edcb8e0 Compare October 5, 2025 18:10
mmcgee-jump
mmcgee-jump reviewed Oct 7, 2025
View reviewed changes
src/discof/tower/fd_tower_tile.c Outdated
fd_ghost_ele_t const * anc = fd_ghost_query_const( ctx->ghost, &msg->reset_block_id );
for( ulong i=0UL; i<FD_TOWER_VOTE_MAX; i++ ) {
if( FD_UNLIKELY( !anc ) ) break;
if( FD_LIKELY( 3 * anc->replay_stake > 2 * ctx->epoch->total_stake ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For optimistic confirmation you want to include gossiped votes as well, which I don't think ghost does

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this out for now

@jherrera-jump jherrera-jump force-pushed the jherrera/gui-shred-vis branch from b96b0bc to e6a1975 Compare October 8, 2025 22:15
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch 2 times, most recently from 5172cd7 to 263977d Compare October 8, 2025 22:20
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-shred-vis branch from e6a1975 to 64dbdce Compare October 8, 2025 22:21
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch from 263977d to f2cdc72 Compare October 8, 2025 22:21
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-shred-vis branch 3 times, most recently from ff25b75 to 57ebccb Compare October 9, 2025 20:09
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch from f2cdc72 to b6e9384 Compare October 9, 2025 20:10
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-shred-vis branch from 57ebccb to 054f398 Compare October 9, 2025 20:12
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch 3 times, most recently from d0a4e40 to e4827eb Compare October 9, 2025 21:15
Base automatically changed from jherrera/gui-shred-vis to main October 9, 2025 22:10
@jherrera-jump
Copy link
Contributor Author

Steady state bandwidth, no compression.

Peak bandwidth can momentarily jump to 250Mbps due to high peer traffic from gossip at valiadtor boot. Otherwise everything seems reasonable.

Total incoming bandwidth: 1.43 Mbps
Incoming bandwidth for ('gossip', 'network_stats')                       :   0.68 Mbps
Incoming bandwidth for ('slot', 'live_shreds')                           :   0.45 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers')                   :   0.20 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall')                 :   0.06 Mbps
Incoming bandwidth for ('peers', 'update')                               :   0.03 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric')           :   0.02 Mbps
Incoming bandwidth for ('slot', 'update')                                :   0.01 Mbps
Incoming bandwidth for ('summary', 'estimated_tps')                      :   0.00 Mbps
Incoming bandwidth for ('gossip', 'peers_size_update')                   :   0.00 Mbps
Total incoming bandwidth: 1.46 Mbps
Incoming bandwidth for ('gossip', 'network_stats')                       :   0.67 Mbps
Incoming bandwidth for ('slot', 'live_shreds')                           :   0.39 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers')                   :   0.20 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall')                 :   0.06 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric')           :   0.02 Mbps
Incoming bandwidth for ('slot', 'update')                                :   0.02 Mbps
Incoming bandwidth for ('peers', 'update')                               :   0.02 Mbps
Incoming bandwidth for ('summary', 'estimated_tps')                      :   0.00 Mbps
Incoming bandwidth for ('summary', 'completed_slot')                     :   0.00 Mbps
Incoming bandwidth for ('summary', 'turbine_slot')                       :   0.00 Mbps
Incoming bandwidth for ('summary', 'root_slot')                          :   0.00 Mbps

@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch 2 times, most recently from 8b290d1 to daab8f5 Compare October 10, 2025 02:30
jherrera-jump
jherrera-jump commented Oct 10, 2025
View reviewed changes
src/discof/replay/fd_replay_tile.c
slot_info->nonvote_failed_txn_count = fd_bank_nonvote_failed_txn_count_get( bank );
slot_info->transaction_count = fd_bank_txn_count_get( bank ) - ( !!parent_bank ? fd_bank_txn_count_get( parent_bank ) : 0UL );
slot_info->nonvote_txn_count = fd_bank_nonvote_txn_count_get( bank ) - ( !!parent_bank ? fd_bank_nonvote_txn_count_get( parent_bank ) : 0UL );
slot_info->failed_txn_count = fd_bank_failed_txn_count_get( bank ) - ( !!parent_bank ? fd_bank_failed_txn_count_get( parent_bank ) : 0UL );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is already accounted for in the runtime, but as a heads up

failed_txn_count and nonvote_failed_txn_count are NOT cumulative in Agave, but they seem to be here.

@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch from daab8f5 to 270c05d Compare October 10, 2025 02:35
@jherrera-jump jherrera-jump marked this pull request as ready for review October 10, 2025 02:36
jherrera-jump
jherrera-jump commented Oct 10, 2025
View reviewed changes
src/disco/gui/fd_gui_peers.c
int vote_eq = peer->has_vote_info
&& !memcmp( peer->vote_account.uc, votes_sorted[ i ].vote_account.uc, sizeof(fd_pubkey_t) )
&& peer->stake ==votes_sorted[ i ].stake
// && peer->last_vote_slot ==votes_sorted[ i ].last_vote_slot
Copy link
Contributor Author

@jherrera-jump jherrera-jump Oct 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the steady state bandwidth if I uncomment these lines (though the gossip table updating live does look cool).

            // && peer->last_vote_slot          ==votes_sorted[ i ].last_vote_slot
            // && peer->last_vote_timestamp     ==votes_sorted[ i ].last_vote_timestamp
            // && peer->epoch_credits           ==votes_sorted[ i ].epoch_credits

Incoming bandwidth for ('peers', 'update')                               :  35.52 Mbps
Incoming bandwidth for ('gossip', 'network_stats')                       :   0.68 Mbps
Incoming bandwidth for ('slot', 'live_shreds')                           :   0.41 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers')                   :   0.20 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall')                 :   0.06 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric')           :   0.02 Mbps
Incoming bandwidth for ('slot', 'update')                                :   0.02 Mbps
Incoming bandwidth for ('gossip', 'peers_size_update')                   :   0.01 Mbps
Incoming bandwidth for ('summary', 'estimated_tps')                      :   0.00 Mbps
Incoming bandwidth for ('summary', 'completed_slot')                     :   0.00 Mbps
Incoming bandwidth for ('summary', 'turbine_slot')                       :   0.00 Mbps
Incoming bandwidth for ('summary', 'root_slot')                          :   0.00 Mbps
Total incoming bandwidth: 36.93 Mbps
Incoming bandwidth for ('peers', 'update')                               :  23.86 Mbps
Incoming bandwidth for ('gossip', 'network_stats')                       :   0.67 Mbps
Incoming bandwidth for ('slot', 'live_shreds')                           :   0.44 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers')                   :   0.20 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall')                 :   0.05 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric')           :   0.02 Mbps
Incoming bandwidth for ('slot', 'update')                                :   0.01 Mbps
Incoming bandwidth for ('gossip', 'peers_size_update')                   :   0.00 Mbps
Incoming bandwidth for ('summary', 'estimated_tps')                      :   0.00 Mbps
Total incoming bandwidth: 25.28 Mbps

@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch 4 times, most recently from b70f322 to a7bd96c Compare October 10, 2025 15:25
@jherrera-jump jherrera-jump force-pushed the jherrera/gui-lsched-votes branch from a7bd96c to 28c1766 Compare October 10, 2025 16:41
@github-actions GitHub Actions
Copy link

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.084847 s 0.084968 s 0.143% ✅
backtest mainnet-368528500-perf snapshot load 2.974 s 2.896 s -2.623% ✅
backtest mainnet-368528500-perf total elapsed 84.847037 s 84.968365 s 0.143% ✅
firedancer mem usage with mainnet.toml 1014.12 GiB 1017.12 GiB 0.296% ✅

@firedancer-io firedancer-io deleted a comment from github-actions bot Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcgee-jump mmcgee-jump mmcgee-jump left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jherrera-jump @mmcgee-jump