-
Notifications
You must be signed in to change notification settings - Fork 339
flamenco/runtime: Add missing log for conformance #6628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
45394d6
to
2d14030
Compare
if( !fd_is_non_migrating_builtin_program( program_id ) && | ||
!fd_is_migrating_builtin_program( ctx->txn_ctx, program_id, &migrated_yet ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason we need these migrating builtin checks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builtin programs should never log "Program is not deployed". My understanding is that the migration status only affects whether they run as native builtin programs or as BPF programs, but they're still always available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize now that we would not have reached this part of the code if we were migrating, removing
Updated the comment
cae95d1
to
93e1766
Compare
93e1766
to
75b9988
Compare
593b45b
to
f056810
Compare
exclude built-ins Update src/flamenco/runtime/program/fd_bpf_loader_program.c Co-authored-by: ripatel-fd <[email protected]> PR feedback Update comment Update commit hash
f056810
to
334b578
Compare
A plethora of outstanding mismatches in
sol_vm_syscall_cpi_c_diff
were caused by a missing"Program is not deployed"
log for the!fd_bpf_upgradeable_loader_state_is_program()
special case. Note that Agave (naturally) excludes built-in programs from this log.Agave reference (
programs/bpf_loader/src/lib.rs:428
):CI will fail until #6575 is merged. That is expected. Until then, this PR will remain in a holding pattern with "WIP" status.