Skip to content

Conversation

cmoyes-jump
Copy link
Contributor

@cmoyes-jump cmoyes-jump commented Oct 6, 2025

A plethora of outstanding mismatches in sol_vm_syscall_cpi_c_diff were caused by a missing "Program is not deployed" log for the !fd_bpf_upgradeable_loader_state_is_program() special case. Note that Agave (naturally) excludes built-in programs from this log.

Agave reference (programs/bpf_loader/src/lib.rs:428):

match &executor.program {
    ProgramCacheEntryType::FailedVerification(_)
    | ProgramCacheEntryType::Closed
    | ProgramCacheEntryType::DelayVisibility => {
        ic_logger_msg!(log_collector, "Program is not deployed");  // <-- THIS IS THE EQUIVALENT LOG
        Err(Box::new(InstructionError::UnsupportedProgramId) as Box<dyn std::error::Error>)
    }
    ProgramCacheEntryType::Loaded(executable) => execute(executable, invoke_context),
    _ => Err(Box::new(InstructionError::UnsupportedProgramId) as Box<dyn std::error::Error>),
}

CI will fail until #6575 is merged. That is expected. Until then, this PR will remain in a holding pattern with "WIP" status.

@cmoyes-jump cmoyes-jump self-assigned this Oct 6, 2025
@cmoyes-jump cmoyes-jump changed the title [WIP / DO NOT MERGE] flamenco/runtime: Add missing log for conformance flamenco/runtime: Add missing log for conformance Oct 7, 2025
Comment on lines 2483 to 2484
if( !fd_is_non_migrating_builtin_program( program_id ) &&
!fd_is_migrating_builtin_program( ctx->txn_ctx, program_id, &migrated_yet ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason we need these migrating builtin checks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builtin programs should never log "Program is not deployed". My understanding is that the migration status only affects whether they run as native builtin programs or as BPF programs, but they're still always available.

Copy link
Contributor Author

@cmoyes-jump cmoyes-jump Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize now that we would not have reached this part of the code if we were migrating, removing

Updated the comment

topointon-jump
topointon-jump previously approved these changes Oct 7, 2025
mjain-jump
mjain-jump previously approved these changes Oct 7, 2025
exclude built-ins

Update src/flamenco/runtime/program/fd_bpf_loader_program.c

Co-authored-by: ripatel-fd <[email protected]>

PR feedback

Update comment

Update commit hash
@cmoyes-jump cmoyes-jump added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit bc987b8 Oct 7, 2025
11 checks passed
@cmoyes-jump cmoyes-jump deleted the cmoyes/logstmt3 branch October 7, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants