-
Notifications
You must be signed in to change notification settings - Fork 339
progcache: support concurrent usage #6653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ class Tile(Enum): | |
BANKF = 29 | ||
RESOLF = 30 | ||
BACKT = 31 | ||
EXEC = 32 | ||
|
||
class MetricType(Enum): | ||
COUNTER = 0 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* THIS FILE IS GENERATED BY gen_metrics.py. DO NOT HAND EDIT. */ | ||
#include "fd_metrics_exec.h" | ||
|
||
const fd_metrics_meta_t FD_METRICS_EXEC[FD_METRICS_EXEC_TOTAL] = { | ||
DECLARE_METRIC( EXEC_PROGCACHE_MISSES, COUNTER ), | ||
DECLARE_METRIC( EXEC_PROGCACHE_HITS, COUNTER ), | ||
DECLARE_METRIC( EXEC_PROGCACHE_FILLS, COUNTER ), | ||
DECLARE_METRIC( EXEC_PROGCACHE_FILL_TOT_SZ, COUNTER ), | ||
DECLARE_METRIC( EXEC_PROGCACHE_FILL_FAILS, COUNTER ), | ||
DECLARE_METRIC( EXEC_PROGCACHE_DUP_INSERTS, COUNTER ), | ||
DECLARE_METRIC( EXEC_PROGCACHE_INVALIDATIONS, COUNTER ), | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* THIS FILE IS GENERATED BY gen_metrics.py. DO NOT HAND EDIT. */ | ||
|
||
#include "../fd_metrics_base.h" | ||
#include "fd_metrics_enums.h" | ||
|
||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_MISSES_OFF (16UL) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_MISSES_NAME "exec_progcache_misses" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_MISSES_TYPE (FD_METRICS_TYPE_COUNTER) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_MISSES_DESC "Number of program cache misses" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_MISSES_CVT (FD_METRICS_CONVERTER_NONE) | ||
|
||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_HITS_OFF (17UL) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_HITS_NAME "exec_progcache_hits" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_HITS_TYPE (FD_METRICS_TYPE_COUNTER) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_HITS_DESC "Number of program cache hits" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_HITS_CVT (FD_METRICS_CONVERTER_NONE) | ||
|
||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILLS_OFF (18UL) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILLS_NAME "exec_progcache_fills" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILLS_TYPE (FD_METRICS_TYPE_COUNTER) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILLS_DESC "Number of program cache insertions" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILLS_CVT (FD_METRICS_CONVERTER_NONE) | ||
|
||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_TOT_SZ_OFF (19UL) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_TOT_SZ_NAME "exec_progcache_fill_tot_sz" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_TOT_SZ_TYPE (FD_METRICS_TYPE_COUNTER) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_TOT_SZ_DESC "Total number of bytes inserted into program cache" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_TOT_SZ_CVT (FD_METRICS_CONVERTER_NONE) | ||
|
||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_FAILS_OFF (20UL) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_FAILS_NAME "exec_progcache_fill_fails" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_FAILS_TYPE (FD_METRICS_TYPE_COUNTER) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_FAILS_DESC "Number of program cache load fails (tombstones inserted)" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_FILL_FAILS_CVT (FD_METRICS_CONVERTER_NONE) | ||
|
||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_DUP_INSERTS_OFF (21UL) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_DUP_INSERTS_NAME "exec_progcache_dup_inserts" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_DUP_INSERTS_TYPE (FD_METRICS_TYPE_COUNTER) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_DUP_INSERTS_DESC "Number of time two tiles raced to insert the same cache entry" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_DUP_INSERTS_CVT (FD_METRICS_CONVERTER_NONE) | ||
|
||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_INVALIDATIONS_OFF (22UL) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_INVALIDATIONS_NAME "exec_progcache_invalidations" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_INVALIDATIONS_TYPE (FD_METRICS_TYPE_COUNTER) | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_INVALIDATIONS_DESC "Number of program cache invalidations" | ||
#define FD_METRICS_COUNTER_EXEC_PROGCACHE_INVALIDATIONS_CVT (FD_METRICS_CONVERTER_NONE) | ||
|
||
#define FD_METRICS_EXEC_TOTAL (7UL) | ||
extern const fd_metrics_meta_t FD_METRICS_EXEC[FD_METRICS_EXEC_TOTAL]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split to enum?
ProgCacheInsertResult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do this and other suggestions discussed in chat in the next PR