update flashtestation logic to use new workload ID computation #331
+10,258
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To account for a bug in the xfam and tdAttributes bitmasking logic, we changed the way the workload ID is calculated in the BlockBuilderPolicy. That PR is here: flashbots/flashtestations#53 This means the workload ID calculation needs to change in any upstream services, which includes op-rbuilder. I've made the same change that I made in the solidity contract here in the attestation.rs logic where op-rbuilder calculates the workload ID. The tests have been updated to use the new correct workload ID, which I obtained by running the BlockBuilderPolicy:workloadIdForTDRegistration function on the same TEE registration that is used in the tests.
Melvillian
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Update the function op-rbuilder uses to calculate the flashtestation's BlockBuilderPolicy's workload ID to use the latest function from flashbots/flashtestations#53
💡 Motivation and Context
To account for a bug in the xfam and tdAttributes bitmasking logic, we changed the way the workload ID is calculated in the BlockBuilderPolicy. That PR is here:
flashbots/flashtestations#53
This means the workload ID calculation needs to change in any upstream services, which includes op-rbuilder.
I've made the same change that I made in the solidity contract here in the attestation.rs logic where op-rbuilder calculates the workload ID. The tests have been updated to use the new correct workload ID, which I obtained by running the BlockBuilderPolicy:workloadIdForTDRegistration function on the same TEE registration that is used in the tests.
✅ I have completed the following steps:
make lintmake test