-
Notifications
You must be signed in to change notification settings - Fork 543
out_s3: Add a description for pure C parquet #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6e4b47e to
b659055
Compare
|
@esmerel Good morning. |
|
@esmerel review needed, see questions above. |
Signed-off-by: Lynette Miles <[email protected]>
We add it to the spelling exceptions file for Vale. I went ahead and did that in #2116 =) And also the heading file, which I should have realized. #2117 |
esmerel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion that looks accidental
0b5a2a3 to
3b4b0d4
Compare
Signed-off-by: Lynette Miles <[email protected]> Signed-off-by: Tom <[email protected]>
patrick-stephens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine other than adding the legacy format config as well.
- Apply suggestion from @esmerel Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
3b4b0d4 to
0e3ab85
Compare
WalkthroughUpdates to the S3 output documentation: corrects the S3 guide link, replaces the compression parameter description with a combined "Compression/format" explanation, and adds detailed Parquet support instructions, build/testing examples, usage notes, and a duplicated Parquet block plus a minor tab/blank formatting tweak. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/outputs/s3.md(4 hunks)
🔇 Additional comments (3)
pipeline/outputs/s3.md (3)
700-723: LGTM on build requirements documentation.The Parquet build requirements section is clear and actionable, with a concrete Ubuntu/Debian example and proper references to external documentation for other distributions.
728-783: LGTM on testing configurations.The example configurations for Parquet testing are well-structured, providing both YAML and conf formats with appropriate settings for testing (debug logging, dummy input with diverse data types, and
use_put_objectenabled).
700-783: Verify: Has the legacy format request been addressed?A previous review comment from patrick-stephens requested: "We should add the legacy format as well." The current Parquet section doesn't explicitly mention legacy compression formats or other format options.
Please clarify:
- Does this PR need to document additional compression formats beyond
gzipandparquet?- If so, should they be added to this section or elsewhere in the documentation?
Signed-off-by: Hiroshi Hatake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/outputs/s3.md(4 hunks)
🔇 Additional comments (4)
pipeline/outputs/s3.md (4)
9-9: ✓ Helpful documentation link update.The change from the CloudWatch Logs S3 link to the official AWS S3 user guide is more appropriate and direct for users referencing S3 capabilities.
39-39: ✓ Comprehensive compression parameter documentation.The expanded
compressiondescription clearly distinguishes between:
- Always-available formats (gzip with
Content-Encodingheader behavior)- Build-time conditional formats (parquet requiring
-DFLB_ARROW=Onand Arrow GLib/Parquet GLib)- Typical usage patterns (Parquet with
use_put_object On)This is precise and helpful for users evaluating their build configuration.
700-722: ✓ Clear build requirements and instructions for Parquet support.The new "Build requirements for Parquet" section provides:
- Specific package installation steps for Ubuntu/Debian
- CMake command with the required
-DFLB_ARROW=Onflag- Reference to upstream Apache Parquet installation docs for other distributions
This guidance aligns well with the parameter documentation and enables users to set up Parquet correctly.
724-781: ✓ Thorough testing section with dual-format examples.The "Testing Parquet support" section includes:
- Complete service and pipeline configuration in both YAML and text (.conf) formats
- Realistic input (dummy input with mixed data types)
- Key Parquet-specific settings (
compression: parquet,use_put_object: On)- Comments noting where additional parameters can be added
Examples are clear and actionable.
| For example: | ||
|
|
||
| {% tabs %} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extraneous blank line in tab markup.
Line 642 contains a blank line immediately after the opening {% tabs %} tag, which appears to be a formatting artifact. This extra whitespace can affect the rendered tab display.
{% tabs %}
-
{% tab title="fluent-bit.yaml" %}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| {% tabs %} | |
| {% tab title="fluent-bit.yaml" %} |
🤖 Prompt for AI Agents
In pipeline/outputs/s3.md around line 642, there is an extraneous blank line
immediately after the opening `{% tabs %}` tag; remove that blank line so the
first tab block/content follows the `{% tabs %}` tag directly (ensure no other
whitespace-only lines exist between the `{% tabs %}` tag and the first `{% tab
%}` or tab content).
Corresponding of fluent/fluent-bit#10691.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.