Fix missing named argument validation in FMT_COMPILE #4555
Closed
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4124
Problem
When using
FMT_COMPILE
with named arguments, missing arguments do not cause compilation errors as they should.While regular
fmt::format("{x}")
correctly fails with a compilation error,FMT_COMPILE
silently falls back to runtime handling, potentially causing runtime errors instead.Solution
Added compile-time validation in the named argument handling path (around line 418 in compile.h). When a named argument is referenced but no arguments are provided (Args is
type_list<>)
, the code now triggers astatic_assert
with a clear error message.Changes