Skip to content

Fix blank code / message due to wrong variable names #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v3
Choose a base branch
from
Open

Fix blank code / message due to wrong variable names #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54a26af
Fix blank error code
Mar 6, 2017
3e74908
Refactor casting
Mar 7, 2017
948b882
Fix for signInWithEmailPassword which was throwing the following erro…
Mar 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ios/Firestack/FirestackAuth.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,8 @@ @implementation FirestackAuth
} else {
NSDictionary *err = @{
@"error": @"createUserWithEmailError",
@"name": @([error code]),
@"description": [error localizedDescription]
@"code": [NSString stringWithFormat:@"%d", [error code]],
@"message": [error localizedDescription]
};
callback(@[err]);
}
Expand Down
4 changes: 2 additions & 2 deletions ios/Firestack/FirestackErrors.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ + (NSDictionary *) handleFirebaseError:(NSString *) name
{
NSMutableDictionary *err = [NSMutableDictionary dictionaryWithObjectsAndKeys:
name, @"name",
@([error code]), @"code",
[error localizedDescription], @"rawDescription",
[NSString stringWithFormat:@"%d", [error code]], @"code",
[error localizedDescription], @"message",
[[error userInfo] description], @"userInfo",
nil];

Expand Down