Skip to content

[fix #321] Fixes the crash when the user opens the app while offline #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix #321] Fixes the crash when the user opens the app while offline #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion android/src/main/java/io/fullstack/firestack/FirestackAuth.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,16 @@ public void userExceptionCallback(Exception exp, final Callback onFail) {
Log.e(TAG, ex.getMessage());
}

onFail.invoke(error);
try {
onFail.invoke(error);
} catch (RuntimeException ex) {
// Firebase tries to login 3 times, so the callback might
// be called as much as that. This will prevent a crash in case
// the callback throws the following error:
// java.lang.RuntimeException: Illegal callback invocation from native module. This callback type only permits a single invocation from native code.
Log.e(TAG, ex.getMessage());
}

}

private WritableMap getUserMap() {
Expand Down