Skip to content

Conversation

@tjhei
Copy link
Member

@tjhei tjhei commented Nov 16, 2025

Clang complains

./aspect/include/aspect/plugins.h:731:13: error: instantiation of
variable
'aspect::internal::Plugins::PluginList<aspect::BoundaryTemperature::Interface<3>>::plugins'
required here, but no definition is available
[-Werror,-Wundefined-var-template]

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line you add doesn't actually do anything. It just says "if you have an instantiation of the class, this member variable exists and is initialized as follows". But unless you have a unity build, you're not actually instantiating anything in this file.

I believe it should work if you moved the lines in question into the header file.

@tjhei tjhei force-pushed the tidy-plugins-warn branch from 7079504 to eae4e55 Compare November 17, 2025 02:56
Clang complains
```
./aspect/include/aspect/plugins.h:731:13: error: instantiation of
variable
'aspect::internal::Plugins::PluginList<aspect::BoundaryTemperature::Interface<3>>::plugins'
required here, but no definition is available
[-Werror,-Wundefined-var-template]
```
@tjhei
Copy link
Member Author

tjhei commented Nov 17, 2025

I believe it should work if you moved the lines in question into the header file.

I am getting linker errors if I do that.

Here is what I am trying to fix by the way (maybe I need to run this locally instead of guessing blindly):
https://github.com/geodynamics/aspect/actions/runs/19410474400/job/55531108392#step:5:173

@bangerth
Copy link
Contributor

Do you have an explicit instantiation of Plugins::PluginList<aspect::BoundaryTemperature::Interface<3>> anywhere (perhaps via a macro)? If so, that place also needs to explicitly instantiate Plugins::PluginList<aspect::BoundaryTemperature::Interface<3>>::plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants