[WIP] Enable dotnet module #136

akien-mga · 2025-11-01T17:12:36Z

Currently hacked on top of classical build, should be split into a separate config as initially we'll still ship separate builds with the .NET module for testing.

akien-mga · 2025-11-01T17:14:36Z

build-dotnet/build.sh

+
+git clone https://github.com/raulsntos/godot-dotnet
+cd godot-dotnet
+git checkout upgrade-assistant-plus-source-code-plugin-wip


Currently it's using the latest commit on the WIP branch.

We'll have to decide whether we want to have a local Git checkout and set the commit manually (like we do for Godot itself), or always build the latest dev branch. I'm not sure how the versioning for godot-dotnet will be like long term.

akien-mga · 2025-11-01T17:15:00Z

build-dotnet/build.sh

+cd godot-dotnet
+git checkout upgrade-assistant-plus-source-code-plugin-wip
+
+./build.sh --productBuild --warnAsError false /p:GenerateGodotBindings=true


Should we build Godot to generate the API json and before building godot-dotnet?

There is a small chance it could break godot-dotnet, so we probably don't want to do this in the script when building a release, we should do it before building a release. We'd push the changes to the repo like godot-cpp (example: godotengine/godot-cpp@e83fd09).

The only difference is godot-cpp makes those commits after a release, and we probably want to do it before the release but after we tagged the commit we'll use for the release. So that we can publish the NuGet packages at the same time.

akien-mga · 2025-11-01T17:15:18Z

build-dotnet/build.sh

+
+./build.sh --productBuild --warnAsError false /p:GenerateGodotBindings=true
+
+cp -r artifacts/packages/Release/Shipping/* /root/out/


I'm assuming this is everything we need to ship?

Yes, those are the only packages we should publish to NuGet.

akien-mga · 2025-11-01T17:16:07Z

build-release.sh

 can_sign_windows=0
 if [ ! -z "${WINDOWS_SIGN_NAME}" ] && [ ! -z "${WINDOWS_SIGN_URL}" ] && [[ $(type -P "osslsigncode") ]]; then
-  can_sign_windows=1
+  can_sign_windows=0


Just a hack because Windows signing currently requires a manual step to unlock the key, so for my test builds I don't bother signing them.

akien-mga · 2025-11-01T17:16:47Z

build-release.sh

-elif [[ "{$templates_version}" == *"-"* ]]; then
-  echo "Templates version (-t) shouldn't contain '-'. It should use a dot to separate version from status."
-  exit 1


Another hack because the logic isn't clever enough to deal with 4.6.dev-dotnet-a4e0a369d, though it's valid for Godot.

akien-mga · 2025-11-01T17:17:57Z

build-release.sh

+  dotnetname="godot-dotnet-${templates_version}"
+  mkdir ${dotnetname}
+  cp out/dotnet/* ${dotnetname}/
+  zip -q -9 -r "${reldir}/${dotnetname}.zip" ${dotnetname}
+  rm -rf ${dotnetname}


Any further steps we can take to make this easier to use?
E.g. provide a Python script that configures a local Nuget source and installs those packages.

We can provide a script, but whatever directory we use can't be removed or it could break restoring packages in any C# project (including non-Godot projects). Also, users would probably want to remove the local NuGet source after the previews and I expect them to forget.

So I think automating this with a script may cause more trouble than the problems it fixes, I'm getting flashbacks to GodotNuGetFallbackFolder.

akien-mga · 2025-11-01T17:18:34Z

build-web/build.sh

+  "target=template_debug dlink_enabled=yes module_dotnet_enabled=yes"
+  "target=template_release dlink_enabled=yes module_dotnet_enabled=yes"


I don't expect Web to work just yet, but if/when it does, I assume it would only work for the dlink_enabled builds (i.e. GDExtension support).

Actually, the WIP PR I made requires the opposite. It didn't work with dlink_enabled because too many symbols or something like that. But we don't need dynamic linking because Mono is linked statically.

We may need the statically-linked Mono template to be separate if we don't want that to be included in GDScript-only projects.

raulsntos · 2025-11-01T18:49:35Z

build-android/build.sh

+  $SCONS platform=android arch=x86_64 $OPTIONS module_dotnet_enabled=yes target=template_debug

  pushd platform/android/java
  ./gradlew generateGodotTemplates


This is the wrong gradle target, we have to use generateGodotMonoTemplates so it includes the .NET .jar dependencies.

raulsntos · 2025-11-01T21:23:41Z

build-dotnet/build.sh

+cd godot-dotnet
+git checkout upgrade-assistant-plus-source-code-plugin-wip
+
+./build.sh --productBuild --warnAsError false /p:GenerateGodotBindings=true


For official releases we want to build with the following options:

./build.sh --productBuild --ci --warnAsError false \ /p:GenerateGodotBindings=true \ /p:VersionPrefix=${version_prefix} \ /p:OfficialBuildId=${build_id} \ /p:FinalVersionKind=${final_version_kind} \ /p:PreReleaseVersionLabel=${prerelease_label}

The --ci and /p:OfficialBuildId options are for making deterministic builds. The /p:VersionSuffix, /p:FinalVersionKind, and /p:PreReleaseVersionLabel options are to override the version of the packages with whatever is passed to the scripts so we match the editor version. (raulsntos@ca22bd4#diff-7ea7ad2452885a8abbd9bc73beed16c3f9cf613f94049bf94b61746c7fc80f1aR30-R74)

raulsntos · 2025-11-01T21:28:20Z

build-dotnet/build.sh

+
+# Config
+
+dnf install -y clang python-unversioned-command


I didn't need to install python-unversioned-command in my changes, is this to fix this error?:

urllib.request.urlretrieve fails with <urlopen error unknown url type: https>

I "fixed" it by downloading the .NET SDK outside of the container. (raulsntos@ca22bd4#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823R273-R285)

But we could alternatively download the .NET SDK with the dotnet install script in the container image, so it's pre-downloaded, and then in this build script we just copy it to the .dotnet directory. We just need to make sure it matches the version required in global.json (which right now is a moving target).

[WIP] Enable dotnet module

db97672

Currently hacked on top of classical build, should be split into a separate config as initially we'll still ship separate builds with the .NET module for testing.

akien-mga requested a review from raulsntos November 1, 2025 17:12

akien-mga commented Nov 1, 2025

View reviewed changes

raulsntos reviewed Nov 1, 2025

View reviewed changes


		./build.sh --productBuild --warnAsError false /p:GenerateGodotBindings=true

		cp -r artifacts/packages/Release/Shipping/* /root/out/

		"target=template_debug dlink_enabled=yes module_dotnet_enabled=yes"
		"target=template_release dlink_enabled=yes module_dotnet_enabled=yes"

Uh oh!

[WIP] Enable dotnet module #136

Are you sure you want to change the base?

[WIP] Enable dotnet module #136

Uh oh!

Conversation

akien-mga commented Nov 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants