Skip to content

Remove CPPEXTPATH changes, add error macros #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove CPPEXTPATH changes, add error macros #1861

wants to merge 1 commit into from
+43 −16

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Oct 6, 2025

In practice, this changes nothing, as CPPEXTPATH was never utilized here. However, with this being reverted in the above repo, this necessitates use of error macro wrappers to handle suppression instead. Those were never properly ported over here, so this PR adds them as well.

@Repiteo Repiteo requested a review from a team as a code owner October 6, 2025 18:50
@Repiteo Repiteo added bug This has been identified as a bug waiting for Godot PRs that can't be merged until an engine PR is merged first regression topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.5 and removed waiting for Godot PRs that can't be merged until an engine PR is merged first labels Oct 6, 2025
@Repiteo Repiteo requested a review from dsnopek October 9, 2025 14:24
dsnopek
dsnopek approved these changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees

No one assigned

Labels

bug This has been identified as a bug cherrypick:4.5 regression topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Repiteo @dsnopek