-
-
Notifications
You must be signed in to change notification settings - Fork 686
Test CMake project with CI #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
32c1754 to
d5664ce
Compare
81bac3a to
9316811
Compare
|
Ping! |
0e9ccc9 to
d4cc5c4
Compare
|
Set minimum python version requirement |
2565f0a to
d925427
Compare
d28c0b8 to
7c91be0
Compare
|
I've rebased PR and updated project for recent version of Godot. |
|
@Calinou Is this something that can be merged in? |
I don't use CMake (and vnen doesn't either), so I don't know if the way this is implemented is correct. Out of curiosity, why was a second |
|
You want cmake lists files per sub section. Having the two is the standard way to do it |
|
@Calinou Would it be of any value for me to test it for validation to merge it in? |
CI checks have passed, so I guess we can test this in production (especially since this won't be cherry-picked to a stable branch due to incompatibilities). Feel free to open a pull request that targets the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Should I backport this PR to branchs for stable Godot version? |
Yes, on |
Includes #456 to fix compilation