Skip to content

Conversation

@o01eg
Copy link
Contributor

@o01eg o01eg commented Feb 25, 2021

Includes #456 to fix compilation

@Calinou Calinou added the enhancement This is an enhancement on the current functionality label Feb 25, 2021
@o01eg o01eg requested a review from Calinou February 26, 2021 05:28
@o01eg o01eg force-pushed the ci-cmake-linux branch 2 times, most recently from 81bac3a to 9316811 Compare March 1, 2021 12:48
@vnen vnen added the topic:buildsystem Related to the buildsystem or CI setup label Mar 1, 2021
@o01eg
Copy link
Contributor Author

o01eg commented Apr 17, 2021

Ping!

@o01eg o01eg force-pushed the ci-cmake-linux branch 3 times, most recently from 0e9ccc9 to d4cc5c4 Compare May 13, 2021 21:07
@o01eg o01eg force-pushed the ci-cmake-linux branch from d4cc5c4 to 88806e2 Compare May 24, 2021 06:56
@o01eg
Copy link
Contributor Author

o01eg commented May 24, 2021

Set minimum python version requirement

@akien-mga akien-mga added this to the 4.0 milestone Sep 27, 2021
@o01eg
Copy link
Contributor Author

o01eg commented Dec 15, 2021

I've rebased PR and updated project for recent version of Godot.

@bradc6
Copy link
Contributor

bradc6 commented Dec 23, 2021

@Calinou Is this something that can be merged in?

@Calinou
Copy link
Member

Calinou commented Dec 24, 2021

@Calinou Is this something that can be merged in?

I don't use CMake (and vnen doesn't either), so I don't know if the way this is implemented is correct.

Out of curiosity, why was a second CMakeLists.txt file was added in the test folder? Isn't the top-level CMakeLists.txt sufficient for this purpose?

@bradc6
Copy link
Contributor

bradc6 commented Dec 24, 2021

You want cmake lists files per sub section. Having the two is the standard way to do it

@bradc6
Copy link
Contributor

bradc6 commented Dec 24, 2021

@Calinou Would it be of any value for me to test it for validation to merge it in?

@Calinou
Copy link
Member

Calinou commented Dec 24, 2021

@Calinou Would it be of any value for me to test it for validation to merge it in?

CI checks have passed, so I guess we can test this in production (especially since this won't be cherry-picked to a stable branch due to incompatibilities).

Feel free to open a pull request that targets the 3.x branch, so the CMake setup can also be tested there 🙂

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit c5fd3d0 into godotengine:master Dec 24, 2021
@o01eg o01eg deleted the ci-cmake-linux branch December 24, 2021 05:40
@o01eg
Copy link
Contributor Author

o01eg commented Dec 24, 2021

Should I backport this PR to branchs for stable Godot version?

@Calinou
Copy link
Member

Calinou commented Dec 24, 2021

Should I backport this PR to branchs for stable Godot version?

Yes, on 3.x specifically.

@o01eg o01eg mentioned this pull request Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants