Skip to content

Conversation

@Faless
Copy link
Contributor

@Faless Faless commented Oct 1, 2021

3.x port of #634 .

Small differences:

  • Default arch is still x86_64, binary suffix is kept as .64 for compatibility(?).
  • The x86_64 build is kept in CI (as it works with the test, and I'm not sure it's safe to update the gdnlib in this branch).

@Faless Faless added enhancement This is an enhancement on the current functionality platform:macos topic:buildsystem Related to the buildsystem or CI setup labels Oct 1, 2021
@Faless Faless added this to the 3.4 milestone Oct 1, 2021
@akien-mga
Copy link
Member

akien-mga commented Oct 1, 2021

Default arch is still x86_64, binary suffix is kept as .64 for compatibility(?).

Since this is for 3.4, maybe we can break compatibility here and default to universal? We build universal binaries since Godot 3.3 already, so defaulting to x86_64 doesn't match official Godot binaries.

Though I haven't checked what Godot expects, maybe it's still something inconsistent like .64 and .arm64?

The x86_64 build is kept in CI (as it works with the test, and I'm not sure it's safe to update the gdnlib in this branch).

I don't think we need to worry about compatibility for the test itself, so it might be fine to port to default to universal too.

@bruvzg
Copy link
Member

bruvzg commented Oct 1, 2021

We can default to universal and use .64 suffix for it, this should work with all existing projects as is.

@Faless Faless force-pushed the osx/3.x_universal branch from fddd025 to de89011 Compare October 2, 2021 15:13
@BastiaanOlij
Copy link
Collaborator

Sounds good to me, I'm even wondering if it should be the only option as there isn't much point of releasing something without support for both.

@akien-mga
Copy link
Member

Sounds good to me, I'm even wondering if it should be the only option as there isn't much point of releasing something without support for both.

I think the option is fine, universal builds take twice the time to build so you might want to build only for your arch during development. Or you might want to provide separate downloads to save on bandwidth/disk size if you have huge binaries.

@akien-mga akien-mga merged commit 8366761 into godotengine:3.x Oct 4, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This is an enhancement on the current functionality platform:macos topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants