Skip to content

Rework debug flags for CMake #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Rework debug flags for CMake #639

merged 1 commit into from
Oct 4, 2021

Conversation

@Shatur
Copy link
Contributor

@Shatur Shatur commented Oct 3, 2021 •
edited
Loading

  • Attach debug flags to the target and mark as PUBLIC. This will allow all
    projects that use bindings not to add the same defines manually.
  • Use generator-expressions to support multiconfig generators (such as
    MSVC).
  • Remove explicit NDEBUG and _DEBUG flags, CMake handles it
    automatically.

@Shatur
Rework debug flags for CMake
2f92b4a 
* Attach debug flags to the target and mark as `PUBLIC`. This will allow all
  projects that use bindings not to add the same defines manually.
* Use generator-expressions to support multiconfig generators (such as
  MSVC).
* Remove excplitic `NDEBUG` and `_DEBUG` flags, CMake handles it
  automatically.
@BastiaanOlij BastiaanOlij added topic:buildsystem Related to the buildsystem or CI setup cmake topic:gdextension This relates to the new Godot 4 extension implementation labels Oct 3, 2021
BastiaanOlij
BastiaanOlij approved these changes Oct 3, 2021
View reviewed changes
Copy link
Collaborator

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@akien-mga akien-mga merged commit d9e643d into godotengine:master Oct 4, 2021
@Shatur Shatur deleted the rework-cmake-debug-flags branch October 4, 2021 07:15
@akien-mga
Copy link
Member

akien-mga commented Oct 4, 2021

Thanks!

Note that this is conflating debug (developers) with debug (tools), which is even worse when reusing the CMAKE_BUILD_TYPE for that. See godotengine/godot-proposals#3371
But this PR doesn't make it worse so it's fine ;)

@akien-mga akien-mga added this to the 4.0 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees

No one assigned

Labels

cmake topic:buildsystem Related to the buildsystem or CI setup topic:gdextension This relates to the new Godot 4 extension implementation

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Shatur @akien-mga @BastiaanOlij