Synced windows compile definitions with scons configuration #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 11, 2021
RedwanFox
force-pushed
the
windows_fix_cmake_configuration
branch
from
87a763b to
32228d8
Compare
RedwanFox
force-pushed
the
windows_fix_cmake_configuration
branch
from
32228d8 to
5336c7e
Compare
akien-mga
approved these changes
Nov 11, 2021
|
Thanks! |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In df9164b9bd7b4505a9918212e39451b75a38a7d7 TYPED_METHOD_BIND definition was added to scons project configuration.
Without it windows method binding fail on compilation