-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Allow the character to flip in both directions #11347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anasmustafa123
wants to merge
4
commits into
godotengine:master
Choose a base branch
from
anasmustafa123:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−7
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e24d120
Allow the character to flip in both directions
anasmustafa123 39db686
Clean up comments in player movement code
anasmustafa123 e1b2f0f
Update getting_started/first_2d_game/03.coding_the_player.rst
anasmustafa123 2df48fa
Allow the character to flip in both directions #11347 (c# code)
anasmustafa123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -271,28 +271,40 @@ movement. Let's place this code at the end of the ``_process()`` function: | |||||||||
|
||||||||||
.. tabs:: | ||||||||||
.. code-tab:: gdscript GDScript | ||||||||||
|
||||||||||
if velocity.x != 0: | ||||||||||
$AnimatedSprite2D.animation = "walk" | ||||||||||
$AnimatedSprite2D.flip_v = false | ||||||||||
# See the note below about the following boolean assignment. | ||||||||||
$AnimatedSprite2D.flip_h = velocity.x < 0 | ||||||||||
elif velocity.y != 0: | ||||||||||
$AnimatedSprite2D.animation = "up" | ||||||||||
$AnimatedSprite2D.flip_v = velocity.y > 0 | ||||||||||
|
||||||||||
# Allow the character to flip in both directions. | ||||||||||
if velocity.x != 0: | ||||||||||
# See the note below about the following boolean assignment. | ||||||||||
$AnimatedSprite2D.flip_v = false | ||||||||||
$AnimatedSprite2D.flip_h = velocity.x < 0 | ||||||||||
if velocity.y != 0: | ||||||||||
$AnimatedSprite2D.flip_v = velocity.y > 0 | ||||||||||
anasmustafa123 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||
|
||||||||||
.. code-tab:: csharp | ||||||||||
|
||||||||||
if (velocity.X != 0) | ||||||||||
{ | ||||||||||
animatedSprite2D.Animation = "walk"; | ||||||||||
|
||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
} | ||||||||||
else if (velocity.Y != 0) | ||||||||||
{ | ||||||||||
animatedSprite2D.Animation = "up"; | ||||||||||
} | ||||||||||
|
||||||||||
# Allow the character to flip in both directions. | ||||||||||
if (velocity.X != 0) | ||||||||||
{ | ||||||||||
animatedSprite2D.FlipV = false; | ||||||||||
// See the note below about the following boolean assignment. | ||||||||||
Comment on lines
302
to
303
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Or flip the order above in GDScript |
||||||||||
animatedSprite2D.FlipH = velocity.X < 0; | ||||||||||
} | ||||||||||
else if (velocity.Y != 0) | ||||||||||
if (velocity.Y != 0) | ||||||||||
{ | ||||||||||
animatedSprite2D.Animation = "up"; | ||||||||||
animatedSprite2D.FlipV = velocity.Y > 0; | ||||||||||
} | ||||||||||
|
||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.