Skip to content

Fix Variant Ref<> assignment. #57968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

Fix Variant Ref<> assignment. #57968

merged 1 commit into from
Feb 11, 2022

Conversation

@reduz
Copy link
Member

@reduz reduz commented Feb 11, 2022 •
edited
Loading

@reduz
Fix Variant Ref<> assignment.
3ad3a43 
-Creating from object pointer via funcptr API was missing reference initialization.
-Supersedes godotengine/godot-cpp#662
-Fixes several crashes in GDExtension
@reduz reduz requested a review from a team as a code owner February 11, 2022 11:32
@BastiaanOlij BastiaanOlij mentioned this pull request Feb 11, 2022
Closed
@Chaosus Chaosus added this to the 4.0 milestone Feb 11, 2022
@mhilbrunner
Copy link
Member

mhilbrunner commented Feb 11, 2022

I can confirm that this fixes the very reproducible crashes I had with a GDExtension.

@groud
Copy link
Member

groud commented Feb 11, 2022

Yep, same for me. I can't tell much whether the implementation is good or not, but well, it solves crashes on my side too.

@akien-mga akien-mga merged commit 275f26c into godotengine:master Feb 11, 2022
@akien-mga
Copy link
Member

akien-mga commented Feb 11, 2022

Thanks!

@zhehangd zhehangd mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

bug topic:core

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@reduz @mhilbrunner @groud @akien-mga @Chaosus