Skip to content

Conversation

Bromeon
Copy link
Contributor

@Bromeon Bromeon commented Jul 13, 2024

@Bromeon
Copy link
Contributor Author

Bromeon commented Jul 13, 2024

I wonder if @param p_is_bitfield is really the best place to mention this? Or should I move it up to the description part?

@dsnopek
Copy link
Contributor

dsnopek commented Jul 15, 2024

Thanks!

I wonder if @param p_is_bitfield is really the best place to mention this? Or should I move it up to the description part?

Personally, I think it'd be better up in the description, since it's better suited to longer text.

@Bromeon Bromeon force-pushed the feature/bitfield-unsigned-docs branch from 7542d2f to b2a9ea6 Compare July 15, 2024 20:37
@Bromeon
Copy link
Contributor Author

Bromeon commented Jul 15, 2024

Updated.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek dsnopek added this to the 4.x milestone Jul 16, 2024
@dsnopek dsnopek requested a review from a team July 16, 2024 14:56
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 17, 2024
@akien-mga akien-mga changed the title GDExtension docs: advise bindings to use uint64_t for bitfields GDExtension docs: Advise bindings to use uint64_t for bitfields Jul 17, 2024
@akien-mga akien-mga merged commit 1d13e95 into godotengine:master Jul 17, 2024
@akien-mga
Copy link
Member

Thanks!

@Bromeon Bromeon deleted the feature/bitfield-unsigned-docs branch July 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants