-
Notifications
You must be signed in to change notification settings - Fork 54
Adding Normalization to java/lang/invoke
#1889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If we decide that this is too aggressive to do by default, then my opinion would be that the normalization is so simple that there is not much value in having it in the plugin behind an opt-in flag. In that case, I would just recommend that we document it in the plugin README or similar. |
src/test/groovy/org/gradle/android/JdkImageWorkaroundTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/gradle/android/JdkImageWorkaroundTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/gradle/android/JdkImageWorkaroundTest.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabriel Féo <[email protected]>
Co-authored-by: Gabriel Féo <[email protected]>
Co-authored-by: Gabriel Féo <[email protected]>
src/test/groovy/org/gradle/android/JdkImageWorkaroundTest.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Gabriel Féo <[email protected]>
Add runtime classpath normalization for
java/lang/invoke/**
inJdkImageWorkaround
.We’ve observed persistent differences on JavaCompile inputs in Android projects even after applying the Android Cache Fix Plugin. These differences stem from JDK image layout/path variations that surface under java/lang/invoke. See the prior discussion in issue #341 for background and examples.
My impression is that this approach might be a bit aggressive. Should we instead do the inverse, where the default behavior is to not apply the normalization?