DCL improvements #45
Open
DCL improvements #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
h0tk3y
commented
Sep 18, 2025
h0tk3y
commented
- Display error messages from DCL analysis in popups over code
- Display the plugins contributing features and projec types
- Add grouping to the model actions in the left pane
eskatos
requested changes
Sep 19, 2025
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions-snapshots/gradle-9.2.0-branch-sigushkinDeclarativeComposability-20250818215312+0000-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions-snapshots/gradle-9.2.0-20250903110058+0000-bin.zip |
There was a problem hiding this comment.
❓ I guess we could use 9.2.0-milestone-2 here
gradle-client/build.gradle.dcl
Outdated
| implementation("org.gradle:gradle-declarative-dsl-tooling-models:9.0-milestone-1") | ||
| implementation("org.gradle:gradle-declarative-dsl-core:9.2.0-milestone-1") | ||
| implementation("org.gradle:gradle-declarative-dsl-evaluator:9.2.0-milestone-1") | ||
| implementation("org.gradle:gradle-declarative-dsl-tooling-models:9.2.0-milestone-1") |
There was a problem hiding this comment.
❓ I guess we could use 9.2.0-milestone-2 here
There was a problem hiding this comment.
❌ Wrapper JAR validation check failed. I don't know where this one is coming from but using the 9.2.0-milestone-2 should work fine.
There was a problem hiding this comment.
Unfortunately, 9.2.0-milestone-2 fails the check just as well.
| GetKotlinBaseDslScriptModel(), | ||
| GetResilientGradleBuild(), | ||
| GetResilientKotlinDslScriptsModel(), | ||
| val modelActionGroups = listOf( |
There was a problem hiding this comment.
👍 Good call adding some structure here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.