This repository was archived by the owner on Jun 4, 2025. It is now read-only.
add default for additional security group param #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| VpcSecurityGroupIds: | ||
| - Fn::ImportValue: !Sub "${VpcStackName}::redshift-public-sg" | ||
| - !Ref AdditionalSecurityGroupParam | ||
| - sg-eff0db9c |
There was a problem hiding this comment.
This is a public repo. I wouldn't hard-code security groups.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added default to empty since prod cluster has only one security group whereas dev has 2 security groups (note: we added this parameter in cloudformation since dev had 2 security groups attached to the cluster)
User-visible Changes
Internal Changes
Links
Testing
Deploy Notes