-
Notifications
You must be signed in to change notification settings - Fork 51
[WIP-01] [Project Solar / Phase 1 / Tokens Pipeline] Main feature branch for $modes support in tokens pipeline and component's CSS compilation
#3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: project-solar/phase-1-main-feature-branch
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
$modes support to tokens pipeline$modes support to tokens pipeline
$modes support to tokens pipeline$modes support in tokens pipeline
$modes support in tokens pipeline$modes support in tokens pipeline
519a6a6 to
3863dfa
Compare
bcb7219 to
fa4bad2
Compare
$modes support in tokens pipeline$modes support in tokens pipeline
$modes support in tokens pipeline$modes support in tokens pipeline
$modes support in tokens pipeline$modes support in tokens pipeline and component's CSS compilation
3863dfa to
a88accd
Compare
fa4bad2 to
3a4d9f2
Compare
|
|
||
| MODES - TODOs | ||
|
|
||
| - Decide if this is a `major` or a `minor` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected to cause breaking changes? If the main result from the consumer standpoint is that themes are added but the default styles/theme stays the same unless they explicitly opt in to using a different theme then we could consider that as a "minor" I think.
a88accd to
5375e7a
Compare
3a4d9f2 to
d7609e3
Compare
5375e7a to
6f015ce
Compare
d7609e3 to
41f911f
Compare
📌 Summary
This is the feature branch for the work needed to add support in the design the tokens pipeline for:
$modestoken values in thesrcJSON filesIt is based on top of #3237
Note: later we may decide to drop this PR and point #3239 directly to #3237 as its base branch
🛠️ Detailed description
This PR will include:
$modessupport to tokens pipeline #3239🔗 External links
Jira ticket (Epic): https://hashicorp.atlassian.net/browse/HDS-5193
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.