Debugging instruqt to fix ssr #2887
Draft
+345
β328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Relevant links
ποΈ What
This change gives a wrapper to posthog imports used in the Instruqt component that were breaking SSR for the site. Added in SSR tests that will fail if SSR breaks again in the future
π€· Why
SSR is extremely important for site SEO
π οΈ How
posthog works off CSR, it's important to have it handled correctly to be rendered after SSR is completed, otherwise it will override the behavior.
πΈ Design Screenshots
how the site looks now with JS disabled when before it was a blank white screen:
π§ͺ Testing
π Anything else?
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.