fixing some conversions #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we record any imports for fields found on either the source or target, but mark the ones that are actually needed in the generated imports as they arise (such as during a type conversion). Also omit referencing the current package by full name from within this package.
dhiaayachi
reviewed
May 26, 2022
dhiaayachi
left a comment
dhiaayachi
left a comment
There was a problem hiding this comment.
I'm not sure this will be merged soon. Please re-request a review if this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we record any imports for fields found on either the source or
target, but mark the ones that are actually needed in the generated
imports as they arise (such as during a type conversion).
Also omit referencing the current package by full name from within this
package.