Skip to content

Conversation

@jrasell
Copy link
Member

@jrasell jrasell commented Oct 24, 2025

Note: new improvement, do not merge until after 1.11 GA.

Nomad 1.11 introduced a new peer cache to store information about Serf peers in order to perform server version checking. This sub-system provides a good place to store all cached Serf peer information which is also stored in the server object.

This change therefore moves the peer and local peer information from the server object into the peer cache backend. It means we have a single place to query this information as well as a single place to reflect Serf membership updates.

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Nomad 1.11 introduced a new peer cache to store information about
Serf peers in order to perform server version checking. This
sub-system provides a good place to store all cached Serf peer
information which is also stored in the server object.

This change therefore moves the peer and local peer information
from the server object into the peer cache backend. It means we
have a single place to query this information as well as a single
place to reflect Serf membership updates.
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that you might want to look at the ENT code base for consumers of these fields, in particular the Autopilot ENT features.

@jrasell jrasell added this to the 1.11.x milestone Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants