Skip to content

Conversation

@jrasell
Copy link
Member

@jrasell jrasell commented Oct 24, 2025

Links

Jira: https://hashicorp.atlassian.net/browse/NMD-757

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

tgross
tgross previously approved these changes Oct 24, 2025
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should check when Consul 1.22 is going GA though... they've got a RC out already so we might be able to update this to show that's out by the time we ship Nomad 1.11.0 GA

@aimeeu aimeeu added the theme/docs Documentation issues and enhancements label Oct 24, 2025
@aimeeu
Copy link
Contributor

aimeeu commented Oct 24, 2025

Last I heard, 10/24 is Consul GA release date.

aimeeu
aimeeu previously approved these changes Oct 24, 2025
@jrasell jrasell merged commit 51140ed into main Oct 29, 2025
17 checks passed
@jrasell jrasell deleted the f-NMD-757 branch October 29, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme/docs Documentation issues and enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants