-
Notifications
You must be signed in to change notification settings - Fork 10k
list: send non-null "config" object to provider when not present in the list block #37620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40e25e6
to
46d0374
Compare
46d0374
to
ffc40fa
Compare
4884439
to
fade75a
Compare
fade75a
to
2247707
Compare
dbanck
reviewed
Sep 23, 2025
dbanck
approved these changes
Sep 24, 2025
3 tasks
dsa0x
added a commit
that referenced
this pull request
Sep 24, 2025
dsa0x
pushed a commit
that referenced
this pull request
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.14-backport
If you add this label to a PR before merging, backport-assistant will open a new PR once merged
no-changelog-needed
Add this to your PR if the change does not require a changelog entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that when a list config isn't given a
config
block, terraform sends a non-null config to the provider RPC. Also, we want to validate the existence of theconfig
block if any of its direct attribute or block is required.Because we were already manually constructing a schema for the list block anyway, I updated that schema to make config required if its direct attribute are required.
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry