Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ quickly merge or address your contributions.

5. The issue is closed.

6. Issues that are not reproducible and/or not gotten responses for a long time are
6. Issues that are not reproducible and/or have not received responses for a long time are
stale issues. In order to provide faster responses and better engagement with
the community, we strive to keep the issue tracker clean and the issue count
low. In this regard, our current policy is to close stale issues after 30 days.
Expand Down
2 changes: 1 addition & 1 deletion api/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const (
HeaderInconsistent = "X-Vault-Inconsistent"

// NamespaceHeaderName is the header set to specify which namespace the
// request is indented for.
// request is intended for.
NamespaceHeaderName = "X-Vault-Namespace"

// AuthHeaderName is the name of the header containing the token.
Expand Down
2 changes: 1 addition & 1 deletion api/sys_plugins.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ func (c *Sys) RegisterPluginWithContext(ctx context.Context, i *RegisterPluginIn
return err
}

// RegisterPluginDetailed wraps RegisterPluginWtihContextDetailed using context.Background.
// RegisterPluginDetailed wraps RegisterPluginWithContextDetailed using context.Background.
func (c *Sys) RegisterPluginDetailed(i *RegisterPluginInput) (*RegisterPluginResponse, error) {
return c.RegisterPluginWithContextDetailed(context.Background(), i)
}
Expand Down
2 changes: 1 addition & 1 deletion changelog/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Release notes are text files with three lines:
- `improvement` - Most updates to the product that aren’t `bug`s, but
aren't big enough to be a `feature`, will be an `improvement`.

2. A component (for example, `secret/pki` or `sdk/framework` or), a colon and a space, and then a one-line description of the change.
2. A component (for example, `secret/pki` or `sdk/framework`), a colon and a space, and then a one-line description of the change.

3. An ending code block.

Expand Down
2 changes: 1 addition & 1 deletion command/agent/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Vault Agent

Vault Agent is a client daemon that provides Auth-Auth, Caching, and Template
Vault Agent is a client daemon that provides Auto-Auth, Caching, and Template
features.

Vault Agent provides a number of different helper features, specifically
Expand Down
6 changes: 3 additions & 3 deletions enos/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Enos

Enos is an quality testing framework that allows composing and executing quality
Enos is a quality testing framework that allows composing and executing quality
requirement scenarios as code. For Vault, it is currently used to perform
infrastructure integration testing using the artifacts that are created as part
of the `build` workflow. While intended to be executed via Github Actions using
Expand Down Expand Up @@ -70,7 +70,7 @@ Additional variable information can also be found in the [Scenario Outlines](#sc
Enos is capable of producing an outline of each scenario that is defined in a given directory. These
scenarios often include a description of what behavior the scenario performs, which variants are
available, and which variables are required. They also provide a step by step breakdown including
which quality requirments are verifiend by a given step.
which quality requirements are verified by a given step.

You can generate outlines of all scenarios or specify one via it's name.

Expand Down Expand Up @@ -122,7 +122,7 @@ The [`ui` scenario](./enos-scenario-ui.hcl) creates a Vault cluster (deployed to
built from the current checkout of the project. Once the cluster is available the UI acceptance tests
are run in a headless browser.
### Variables
In addition to the required variables that must be set, as described in the [Scenario Variables](#Scenario Variables),
In addition to the required variables that must be set, as described in the [Scenario Variables](#scenario-variables),
the `ui` scenario has two optional variables:

**ui_test_filter** - An optional test filter to limit the tests that are run, i.e. `'!enterprise'`.
Expand Down
2 changes: 1 addition & 1 deletion physical/foundationdb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ By default, if `--fdbver x.y.z` is not specified, version 5.2.4 will be used.

## Building Vault

To build Vault the FoundationDB backend, add FDB_ENABLED=1 when invoking
To build Vault with the FoundationDB backend, add FDB_ENABLED=1 when invoking
`make`, e.g.

```
Expand Down
2 changes: 1 addition & 1 deletion physical/foundationdb/fdb-go-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ else
golibdir=$(dirname "${GOPATH}/src/${REMOTE}/${FDBREPO}")
if [[ -z "${destdir}" ]] ; then
if [[ "${operation}" == "localinstall" ]] ; then
# Assume its the local directory.
# Assume it's the local directory.
destdir=$(cd "${filedir}/../../.." && pwd)
else
destdir="${golibdir}"
Expand Down
2 changes: 1 addition & 1 deletion ui/docs/client-pagination.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Client-side pagination

Our custom `pagination` service allows us to paginate LIST responses while maintaining good performance, particularly when the LIST response includes tens of thousands of keys in the data response. It does this by caching the entire response, and then filtering the full response into the datastore for the client. It was originally a custom method in our `store` service that extended the ember-data `store` but now is it's own `pagination` service.
Our custom `pagination` service allows us to paginate LIST responses while maintaining good performance, particularly when the LIST response includes tens of thousands of keys in the data response. It does this by caching the entire response, and then filtering the full response into the datastore for the client. It was originally a custom method in our `store` service that extended the ember-data `store` but now is its own `pagination` service.

## Using pagination

Expand Down
4 changes: 2 additions & 2 deletions ui/docs/css.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
> The following are known issues that we are working to address in conjunction with the adoption of HDS.
> 1. **Size variables** The UI does not follow a consistent size variable pattern. We use both px and rem to define font-size and we use px, rem, and ems to define margins, heights and widths. For accessibility reasons we _should_ define all font-sizing at the very least by rem, though this is not consistently done in the app.
> 2. **Variable naming** The UI does not have a consistent pattern to variable naming. We use a mix of numbers and words (ex: `ui-gray-050` is the same as `ui-gray-lightest`).
> 3. **Random variables** We have dieing but not dead variables. For example, we have some variables that define box-shadows and we have some variables to define animations, but we are missing many box-shadow definitions and we do not consistently use the animation variables.
> 4. **Missing variables** The UI does not have a variable for all commonly occurring sizes and colors. For example, we do not have a variable that covers the `14px` though it is a commonly used size.
> 3. **Random variables** We have dying but not dead variables. For example, we have some variables that define box-shadows and we have some variables to define animations, but we are missing many box-shadow definitions and we do not consistently use the animation variables.
> 4. **Missing variables** The UI does not have variables for all commonly occurring sizes and colors. For example, we do not have a variable that covers the `14px` though it is a commonly used size.
> 5. **!Important** `!important` is sprinkled throughout helper, core and component files. Ideally, the cascading and order of styles would eliminate the need of this keyword. However, because `!important` exist randomly in many of our files, we now have cascading issues inside helper files and core files. In all known cases where these issues exist a comment has been left as to why the order of classes in that particular area matters.

### Helper classes
Expand Down
2 changes: 1 addition & 1 deletion ui/docs/routing.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Instead of extending route classes to share this `isConfigured` state, consider

### [@withConfirmLeave()](../lib/core/addon/decorators/confirm-leave.js)

- Renders `window.confirm()` alert that a user has unsaved changes if navigaing away from route with the decorator
- Renders `window.confirm()` alert that a user has unsaved changes if navigating away from route with the decorator
- Unloads or rolls back Ember data model record

<!-- TODO add withConfig() if we refactor for more general use -->
Expand Down
2 changes: 1 addition & 1 deletion ui/docs/tests.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Test Helpers Organization

Our test are constantly evolving, but here's a general overview of how we set up and organize tests.
Our tests are constantly evolving, but here's a general overview of how we set up and organize tests.

## Folder organization

Expand Down