Skip to content

Mobile Config filter Boosted Hexes #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 8, 2024
Merged

Mobile Config filter Boosted Hexes #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c896a82
Refactor to use BoostedHexes methods
michaeldjeffrey Apr 24, 2024
2b558ca
Add device type to boosted hex info
michaeldjeffrey Apr 24, 2024
8091ceb
refactor metadata_db tests to make test clearer
michaeldjeffrey May 1, 2024
8767a15
remove expired boosted hexes when streaming from db
michaeldjeffrey May 1, 2024
fb80d44
ensure no tests are written with expired boosted hexes
michaeldjeffrey May 1, 2024
dde0707
optimize by computing end_ts in db query
michaeldjeffrey May 1, 2024
18fc99a
fixup after rebase
michaeldjeffrey May 6, 2024
66b36d8
make boosted hex test function more explicit
michaeldjeffrey May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boost_manager/src/activator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ where
manifest: RewardManifest,
) -> Result<()> {
// get latest boosted hexes info from mobile config
let boosted_hexes = BoostedHexes::get_all(&self.hex_boosting_client).await?;
let boosted_hexes = BoostedHexes::get_active(&self.hex_boosting_client).await?;

// get the rewards file from the manifest
let manifest_time = manifest.end_timestamp;
Expand Down
6 changes: 3 additions & 3 deletions boost_manager/tests/integrations/activator_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ impl TestContext {
async fn test_activated_hex_insert(pool: PgPool) -> anyhow::Result<()> {
let now = Utc::now();
let ctx = TestContext::setup(now)?;
let boosted_hexes = BoostedHexes::new(ctx.boosted_hexes);
let boosted_hexes = BoostedHexes::test_new_active(ctx.boosted_hexes)?;

// test a boosted hex derived from radio rewards
// with a non set start date, will result in a row being
Expand Down Expand Up @@ -117,7 +117,7 @@ async fn test_activated_hex_insert(pool: PgPool) -> anyhow::Result<()> {
async fn test_activated_hex_no_insert(pool: PgPool) -> anyhow::Result<()> {
let now = Utc::now();
let ctx = TestContext::setup(now)?;
let boosted_hexes = BoostedHexes::new(ctx.boosted_hexes);
let boosted_hexes = BoostedHexes::test_new_active(ctx.boosted_hexes)?;

// test a boosted hex derived from radio rewards
// with an active start date, will result in no row being
Expand All @@ -143,7 +143,7 @@ async fn test_activated_hex_no_insert(pool: PgPool) -> anyhow::Result<()> {
async fn test_activated_dup_hex_insert(pool: PgPool) -> anyhow::Result<()> {
let now = Utc::now().with_second(0).unwrap();
let ctx = TestContext::setup(now)?;
let boosted_hexes = BoostedHexes::new(ctx.boosted_hexes);
let boosted_hexes = BoostedHexes::test_new_active(ctx.boosted_hexes)?;

// test with DUPLICATE boosted hexes derived from radio rewards
// with a non set start date, will result in a single row being
Expand Down
Loading