Skip to content

Conversation

ahmadi-akbar
Copy link

fix #3055

@ahmadi-akbar ahmadi-akbar requested review from a team as code owners July 1, 2025 16:56
@ahmadi-akbar ahmadi-akbar requested a review from agadzhalov July 1, 2025 16:56
@lfdt-bot
Copy link
Contributor

lfdt-bot commented Jul 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@ivaylonikolov7
Copy link
Contributor

ivaylonikolov7 commented Jul 1, 2025

Hello @ahmadi-akbar . Thank you for contribution 🙌

Just a couple of questions on the PR. How would that fix the issue for you? As far as I understood this will still install the react-native-get-random-values unless there is some network issues? This will install on all platforms regardless of optional:true flag. My understanding of the optional:true flag is that it wouldn't break the install operation if it fails on specific platforms or isn't able to download the package.

@ahmadi-akbar
Copy link
Author

@ivaylonikolov7 ivaylonikolov7 closed this pull request by merging all changes into hiero-ledger:main in d675311 Jul 1, 2025
@ivaylonikolov7
Copy link
Contributor

ivaylonikolov7 commented Jul 1, 2025

Hm weird. Sorry, something happened with Github when I merged a dependabot PR, the pull bot force pushed on your PR and when I merged it said I merged your changes.

I read the peerDependenciesMeta field. I will check if it makes any breaking changes on our already existing users. I will recreate the PR so you don't waste time. But you can recreate it. Sorry about the bot force pushing.

@ivaylonikolov7
Copy link
Contributor

ivaylonikolov7 commented Jul 1, 2025

Recreated your PR here - #3203 @ahmadi-akbar. We can continue the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove react-native-get-random-values dependency from cryptography package
3 participants