Skip to content
This repository was archived by the owner on Sep 20, 2021. It is now read-only.

Conversation

@sanmai
Copy link

@sanmai sanmai commented Mar 8, 2020

Also remove HHVM: it is not going to be PHP-compatible going forward.

@coveralls
Copy link

coveralls commented Mar 8, 2020

Coverage Status

Coverage remained the same at ?% when pulling c8d286d on sanmai:patch-2 into c620f44 on hoaproject:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 6af2e13 on sanmai:patch-2 into c620f44 on hoaproject:master.

@ohader
Copy link

ohader commented Oct 6, 2020

Addressed in PR #114 - unfortunately there's much more to do in order to get complete support for PHP 7.4

  • fix/release hoa/test being compatible with PHP 7.4
  • adjust hoa/console to call php-cs-fixer with --allow-risky CLI argument
  • basically fix & bump all hoa packages for PHP 7.4 compat & switch to new versioning schema (e.g. all packages sharing same major/minor version)

Anyway, I think this PR can be closed → #114

@sanmai
Copy link
Author

sanmai commented Oct 6, 2020

Sure, about time.

@sanmai sanmai closed this Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants