🚨 [v5] Rendundant code in nested configs #41314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
approved these changes
Oct 6, 2025
| semantic_config = {} | ||
| logger.info("semantic_config is None. initializing the semantic model with default values.") | ||
| semantic_config = BarkSemanticConfig() | ||
| logger.info("`semantic_config` is `None`. Initializing the `BarkSemanticConfig` with default values.") |
There was a problem hiding this comment.
Let's remove those logs instead wdyt? One of the v5 goals is to have fewer and more informatives warnings and logs!
There was a problem hiding this comment.
oke, they are not super informative anyway
Comment on lines
+295
to
+304
| @property | ||
| def sub_configs(self): | ||
| sub_configs = {} | ||
| backbone_config = getattr(self, "backbone_config", None) | ||
| text_config = getattr(self, "text_config", None) | ||
| if isinstance(backbone_config, PretrainedConfig): | ||
| sub_configs["backbone_config"] = type(backbone_config) | ||
| if isinstance(text_config, PretrainedConfig): | ||
| sub_configs["text_config"] = type(self.text_config) | ||
| return sub_configs |
There was a problem hiding this comment.
Was just removed by your other PR no? We should not add it again!
There was a problem hiding this comment.
yeah, the two PRs will conflict, I will merge the other first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR deletes
from_xxx_configand similar methods from everywhere and instead ensures that the config init can accept subconfigs of all formats (dict or object)Along the way, I found that not all configs call super init in the end and thus they can't set recursively attn implementation on subconfigs. I added a test for it and fixed all cases