- 
                Notifications
    
You must be signed in to change notification settings  - Fork 31k
 
make some ut cases pass on xpu w/ latest torch #41337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yao, Matrix <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! Any idea what caused the outputs to change for xpu ?
          
 @SunMarc, XPU is still stabilizing the op implementations, Hugging Face, vLLM and other top-of-stack libraries are keeping report founded bugs or issues to them, and Intel PyTorch team is keeping fixing bugs and improving numerical behaviors, so the op implementations are keep enhancing rather than keeping still, which will impact model-level output. The good thing is: the output is more and more CUDA alike, which means the op enhancement is towards to CUDA-numerical-compatible way.  | 
    
| 
           [For maintainers] Suggested jobs to run (before merge) run-slow: aya_vision, gemma3, llava, llava_onevision  | 
    
| 
           @bot /style  | 
    
| 
           Style bot fixed some files and pushed the changes.  | 
    
| 
           The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.  | 
    
* make some ut cases pass on xpu w/ latest torch Signed-off-by: Yao, Matrix <[email protected]> * Update test_modeling_llava_onevision.py * Apply style fixes --------- Signed-off-by: Yao, Matrix <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
make below 12 cases pass on XPU w/ latest torch.
@SunMarc @ydshieh , pls help review, thx very much.