Skip to content

server: Ignore NotConnected errors on shutdown #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

server: Ignore NotConnected errors on shutdown #654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c11e186
server: Ignore `NotConnected` errors on shutdown
LucioFranco Dec 14, 2022
ebe537a
Apply suggestions from code review
LucioFranco Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/proto/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,18 @@ where
State::Closing(reason, initiator) => {
tracing::trace!("connection closing after flush");
// Flush/shutdown the codec
ready!(self.codec.shutdown(cx))?;
if let Err(e) = ready!(self.codec.shutdown(cx)) {
// If the error kind is NotConnected, ignore it, since
// it just means the connection is already shutdown.
if e.kind() != io::ErrorKind::NotConnected {
return Poll::Ready(Err(e.into()));
} else {
tracing::trace!(
"ignoring NotConnected error \
(the connection has already closed)"
);
}
}

// Transition the state to error
self.inner.state = State::Closed(reason, initiator);
Expand Down