Skip to content

chore | Proto change for adding evaluation targets for each exclude span rule #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore | Proto change for adding evaluation targets for each exclude span rule #220

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f26e5ca
Proto change for adding evaluation targets for each exclude span rule
AnandShivansh Jun 7, 2024
8f9a405
Proto change for adding evaluation targets for each exclude span rule
AnandShivansh Jun 7, 2024
b5eba24
Proto change for adding evaluation targets for each exclude span rule
AnandShivansh Jun 10, 2024
2c65a92
Merge branch 'main' into proto_change
AnandShivansh Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...oto/org/hypertrace/span/processing/config/service/v1/span_processing_config_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ message DeleteExcludeSpanRuleResponse {
message ExcludeSpanRule {
string id = 1;
ExcludeSpanRuleInfo rule_info = 2;
repeated EvaluationTarget evaluation_targets = 3;
}

message ExcludeSpanRuleDetails {
Expand All @@ -68,6 +69,20 @@ message ExcludeSpanRuleInfo {
RuleType type = 4;
}

message EvaluationTarget {
oneof target {
Platform platform = 1;
Agent agent = 2;
AgentModule agent_module = 3;
}
}

message Platform {}

message Agent {}

message AgentModule {}

message ExcludeSpanRuleMetadata {
google.protobuf.Timestamp creation_timestamp = 1;
google.protobuf.Timestamp last_updated_timestamp = 2;
Expand Down