Skip to content

ENGTAI-63748: patch to unwind text array exp for postgres #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ENGTAI-63748: patch to unwind text array exp for postgres #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...trace/core/documentstore/postgres/query/v1/vistors/PostgresFromTypeExpressionVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public class PostgresFromTypeExpressionVisitor implements FromTypeExpressionVisi
private static final String PRESERVE_NULL_AND_EMPTY_TABLE_QUERY_FMT =
"%s as (SELECT * from %s %s LEFT JOIN LATERAL %s %s on TRUE)";
private static final String UNWIND_EXP_FMT = "jsonb_array_elements(%s)";
private static final String UNWIND_TEXT_ARRAY_EXP_FMT = "unnest(%s)";
private static final String UNWIND_EXP_ALIAS_FMT = "p%s(%s)";

private PostgresQueryParser postgresQueryParser;
Expand Down Expand Up @@ -52,9 +53,17 @@ public String visit(UnnestExpression unnestExpression) {
String preTable = "table" + preIndex;
String newTable = "table" + nextIndex;
String tableAlias = "t" + preIndex;
String unwindExpr = String.format(UNWIND_EXP_FMT, transformedFieldName);
String unwindExprAlias = String.format(UNWIND_EXP_ALIAS_FMT, nextIndex, pgColumnName);

// patch if the collection has non-json fields
String flatStructureCollection = postgresQueryParser.getFlatStructureCollectionName();
String unwindExpr =
(flatStructureCollection != null
&& flatStructureCollection.equals(
postgresQueryParser.getTableIdentifier().getTableName()))
? String.format(UNWIND_TEXT_ARRAY_EXP_FMT, transformedFieldName)
: String.format(UNWIND_EXP_FMT, transformedFieldName);

String fmt =
unnestExpression.isPreserveNullAndEmptyArrays()
? PRESERVE_NULL_AND_EMPTY_TABLE_QUERY_FMT
Expand Down