-
Notifications
You must be signed in to change notification settings - Fork 39
fix: removed support for experimental loader flag #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5-release
Are you sure you want to change the base?
Conversation
66f40a8 to
0b41e6e
Compare
af69d60 to
70826e1
Compare
| if (esmUtil.hasExperimentalLoaderFlag()) { | ||
| // eslint-disable-next-line no-console | ||
| console.error( | ||
| 'Node.js introduced breaking changes in versions 18.19.0 and above, leading to the discontinuation of support ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
introduced breaking changes
IMO this is too much information without a link to their breaking change.
Thats why IMO:
For Node.js versions later than 18.19, the --experimental-loader flag and ESM support are no longer available.
|
|
||
| // This loader worked with '--experimental-loader' in Node.js versions below 18.19. | ||
| // TODO: Remove 'esm-loader.mjs' file and this log in the next major release (v6). | ||
| if (esmUtil.hasEsmLoaderFile()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use case here is:
--import esm-loader.mjs
Right?
Its very nice to catch the wrong usage - especially because we drop the syntax.
I feel like the error message is not on point?
|
We need a todo to cleanup task for internal Github usages of "--experimental-loader". |
BREAKING CHANGE
Notes:
--experimental-loaderis already not working for Node versions >= v18.19.0 (documented already)esm-loader.mjsworks with--experimental-loaderonly.We are dropping support for < v18.19.
Reference
Autotrace webhook: https://github.ibm.com/instana/autotrace-mutating-webhook/pull/670