[CLX-3244][Horizon] Replace deprecated hiltViewModel calls #3402
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR updates the import statement for hiltViewModel across 23 files from the deprecated androidx.hilt.navigation.compose.hiltViewModel to the new androidx.hilt.lifecycle.viewmodel.compose.hiltViewModel package.
✅ Positive Aspects
- Proper Migration: This correctly migrates to the new Hilt ViewModel API that's part of the lifecycle extensions
- Comprehensive Coverage: All affected files in the horizon module have been updated consistently
- Clean Changes: The changes are focused and don't introduce unnecessary modifications
- Backwards Compatibility: The new import maintains the same API surface, so no code changes beyond imports are needed
- Unused Import Cleanup: In
DashboardSkillOverviewWidget.kt, an unused import (androidx.compose.foundation.layout.fillMaxWidth) was appropriately removed
📋 Checklist
No issues found - this is a straightforward dependency migration that follows best practices.
🔍 Code Quality
The changes demonstrate good code hygiene:
- Consistent import updates across all files
- No deprecated API usage remaining
- Proper package structure following AndroidX conventions
🧪 Testing Considerations
Since this is purely an import change with no functional modifications:
- Existing tests should continue to pass without changes
- The new import provides the same functionality as the old one
- No new test coverage is required for this change
📚 Context
The androidx.hilt.navigation.compose package has been deprecated in favor of androidx.hilt.lifecycle.viewmodel.compose as part of AndroidX's restructuring to better align with lifecycle and viewmodel packages. This migration is necessary to avoid deprecation warnings and ensure future compatibility.
Overall Assessment: This is a well-executed dependency migration. The changes are correct, comprehensive, and follow Android development best practices. ✨
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
|
Student Install Page |
refs: CLX-3244
affects: Student
release note: none