[Student] Allow Document Scan to Fallback to PDFs #3670
Merged
+64
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd not jpegs refs: none builds: Student, Teacher affects: Student release note: none test plan: - Launch app - Test scanner submission of assigment that allows pdfs and not jpegs
gozelski
requested review from
rh12,
suhaibabsi-inst and
vargaat
as code owners
gozelski
changed the title
gozelski
changed the title
gozelski
changed the title
Contributor
suhaibabsi-inst
left a comment
suhaibabsi-inst
left a comment
There was a problem hiding this comment.
Thanks for making this PR.
Would be great to address the following points.
- rename: PDFDocument.write(nameIt:) -> PDFDocument.write(name:) - put temporary pdf documents in `Documents/` instead of `documents/` - Only append `.pdf` path extension if it is not already applied Co-authored-by: Suhaib Al-Absi <[email protected]>
suhaibabsi-inst
changed the base branch from
master
to
feature/MBL-19549-Merge-Scanned-Images-Into-PDF-Document
suhaibabsi-inst
merged commit 98c1043
into
instructure:feature/MBL-19549-Merge-Scanned-Images-Into-PDF-Document
0 of 2 checks passed
Contributor
|
Will be moving forward with this, and eventually it will make it into our master branch just before the intended release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VisionKit Document Scanner is now enabled for assigments that allow pdfs and not images, submitting the scanned document as a multipage pdf.
refs: none
builds: Student, Teacher
affects: Student
release note: none
test plan:
This is visually the same as uploading JPEGs; the only difference lies when saving: the file outputted is a single multipage pdf.
"Failed to save pdf" is most likely not localized; this could reverted to the same string as images, be localized, or use another already localized string.
Checklist