[CLX-3259][S] Dashboard course refactor

[Ahmed-Naguib93]

What is new?

1- Fix tab bar issue at iOS 26
2- Update dashboard course
For fixing the tab bar, I have tested on iPhones and iPads running iOS 18 and 16.

refs: CLX-3259
builds: Student
affects: Student
release note: none

[claude]

Claude Code Review

Updated: 2025-11-09

Critical Issues Found

• Breaking Tab Bar Logic: Removed shouldPresentChatBot check in HorizonTabBarController:143. Now always calls presentChatBot() for tab index 2, breaking iOS version/device guard. Will crash on non-iPad devices.

• Filter UI State Inconsistency: When resetting filter to All in CourseListView, the selectedStatus state variable never updates. Creates mismatch between visual filter selection and displayed courses.

• Accessibility Focus Race Condition: Hard-coded 1-second delay in restoreFocusIfNeeded() (line 185) is unreliable on slow devices or large lists.

Issues found

[inst-danger]

	Warnings
⚠️	This pull request will not generate a release note.
⚠️	One or more files are below the minimum test coverage 50%
⚠️	The total test coverage is below the minimum 90%

Affected Apps: Student

Builds: Student

Coverage	New %	Master %	Delta
Canvas iOS	81.02%	81.06%	-0.04%
Horizon/Horizon/Sources/Features/Dashboard/SkillsHighlightsWidget/Data/ProficiencyLevel.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Notebook/Common/View/HighlightWebView/EnableZoom.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Notebook/Common/View/HighlightWebView/HighlightWebFeature.swift	0%	0%	0%
Horizon/Horizon/Sources/Common/Domain/GetCoursesInteractor.swift	38.16%	38.16%	0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/SubmissionComment/Data/CommentAttachment.swift	0%	0%	0%
Horizon/Horizon/Sources/Common/Data/HModuleStatus.swift	0%	0%	0%
Horizon/Horizon/Sources/Common/Utilities/Double+.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Account/Notifications/Domain/NotificationSettingsInteractor.swift	0%	0%	0%
Horizon/Horizon/Sources/Features/Session/SessionInteractor.swift	33.33%	33.33%	0%
Horizon/Horizon/Sources/Features/Assist/AssistFlashCard/View/AssistFlashCardViewModel.swift	0%	0%	0%

Generated by 🚫 dangerJS against 3fc92a7

[inst-danger]

Builds

Commit: Add padding (3fc92a7)
Build Number: 778
Built At: Nov 17 22:21 CET (11/17 02:21 PM MST)

Student

[claude]

Claude Code Review - Updated 2025-11-09

Critical Issue

• Tab Bar Logic Regression: Removed shouldPresentChatBot guard in HorizonTabBarController. Now unconditionally calls presentChatBot() for tab 2, breaking device checks and will crash on non-iPad.

Issues Found

• Pagination Bug: After currentPage increment, guard checks currentPage+1 then accesses paginatedCourses[currentPage]. Prevents final page load.
• Filter State Not Synced: CourseFilteringView uses State instead of Binding, so parent state changes won't update UI after first interaction.

✅ Compiles, tests added, strings complete.

[claude]

Claude Code Review

Updated: 2025-11-17

Critical Issues

• Tab Bar Regression (HorizonTabBarController:143): Removed shouldPresentChatBot guard. Now unconditionally calls presentChatBot() for tab 2, breaking iOS 16 compatibility check. Will crash on non-iPad devices.

• Pagination Bug (CourseListViewModel:83-86): In seeMore(), increments currentPage then guards currentPage < totalPages, preventing final page load. Should check before incrementing or use <=.

• Filter State Mismatch (CourseFilteringView): Takes selectedStatus parameter but CourseListView uses State. Parent filter changes don't propagate; use Binding instead.

✅ Compiles | ✅ Tests added