-
Notifications
You must be signed in to change notification settings - Fork 121
[MBL-19375] To-do Filters #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vargaat
wants to merge
26
commits into
master
Choose a base branch
from
feature/MBL-19375-todo-filters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
782fdb4
Add new date formatting helpers.
vargaat 1624b7b
Add primitives for filtering.
vargaat 64fc7e1
Add persistence for filter options.
vargaat 02d9c8f
[MBL-19375] Add Todo filter screen UI and ViewModel
vargaat ec11ae9
Use router.show for filter screen and optimize callbacks
vargaat e93bf63
Merge branch 'master' into feature/MBL-19375-todo-filters
vargaat bb3bedc
Fix account plannables not being recognized.
vargaat 40ee45b
Refactor Todo filtering to use local filtering with cache-aware loading
vargaat e260674
Update GetPlannables to allow fetching without any context codes.
vargaat b408c62
Merge branch 'master' into feature/MBL-19375-todo-filters
vargaat f5866c9
Merge branch 'master' into feature/MBL-19375-todo-filters
vargaat 330545f
Refactor swipe gesture to support configurable completion behavior
vargaat 2024e8c
Update unit tests.
vargaat 5be3782
Add analytics events for todo list filter loading
vargaat d0cb440
Cleanup.
vargaat 929f91e
Add support to display all day and time interval based events.
vargaat ae711ee
Merge branch 'master' into feature/MBL-19375-todo-filters
vargaat 00214e8
Fix swipe action bug and refactor to item-level behavior
vargaat c5dd157
Fix To-do scroll not working on iOS 26.
vargaat cae0e51
Fix UI state not being in sync with DB.
vargaat 6e55160
Isolate Plannable objects used for Todo items from Calendar Plannables.
vargaat 07c15e8
Make account events non-tappable.
vargaat e0cf63a
Code cleanup.
vargaat 0ef41cb
Refresh todo list on app foreground events.
vargaat 50ada6f
Fix GetPlannablesTests cache key
vargaat 508277f
Fix test timing and locale issues
vargaat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it would make sense to combine the old and new comments, as it is somewhat confusing this way.