[V12] feat(ui-metric): rework Metric #2240
Conversation
|
| ### Upgrade Guide for V12 | ||
|
|
||
| > - theme variable `padding` is now removed, left-right padding can be set now with the `paddingHorizontal` theme variable | ||
| > - theme variable `fontFamily` is now removed, font can be set independently on the value and label elements using the `valueFontFamily` and `labelFontFamily` variables respectively | ||
There was a problem hiding this comment.
I put the upgrade guides in the README.md as suggested by Topi, but I can copy these in the Upgrade Guide for Version 12 file started by Matyi
There was a problem hiding this comment.
I think these should all the in the same place, the upgrade guide. We dont want to instruct users to open 50+ Readme files.
INSTUI-4838
ToMESSKa
force-pushed
the
INSTUI-4838-metric-rework
branch
from
fffc950 to
4ef79e6
Compare
| ### Upgrade Guide for V12 | ||
|
|
||
| > - theme variable `padding` is now removed, left-right padding can be set now with the `paddingHorizontal` theme variable | ||
| > - theme variable `fontFamily` is now removed, font can be set independently on the value and label elements using the `valueFontFamily` and `labelFontFamily` variables respectively | ||
There was a problem hiding this comment.
I think these should all the in the same place, the upgrade guide. We dont want to instruct users to open 50+ Readme files.
| ref: Element | null = null | ||
| const styles = useStyle({ | ||
| generateStyle, | ||
| generateComponentTheme, |
There was a problem hiding this comment.
generateComponentTheme is no longer used, you can delete it from here and the file too.
| isGroupChild: MetricProps['isGroupChild'] | ||
| themeOverride?: MetricProps['themeOverride'] |
There was a problem hiding this comment.
You dont need to supply these 2, they are not used.
| handleRef = (el: Element | null) => { | ||
| this.ref = el | ||
| } | ||
| useImperativeHandle(ref, () => elementRef.current as HTMLDivElement) |
There was a problem hiding this comment.
Is this needed for ref? Wont this value returned by default?
| generateComponentTheme, | ||
| componentId: 'MetricGroup', | ||
| displayName: 'MetricGroup' | ||
| }) |
There was a problem hiding this comment.
hmm this is not nice, we have to improve useStyle so it can nicely handle style.ts files which have no theme (in a different PR). Can you please put a TODO comment to useStyle that it should be improved to handle generateStyle functions, that dont use params or dont have a theme?
INSTUI-4838
ISSUE:
TEST PLAN: