Add element_size function for Dataset elements #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markovamaria
requested review from
Alexsandruss,
ahuber21,
dian-lun-lin,
ibhati,
mihaic and
yuejiaointel
as code owners
markovamaria
force-pushed
the
add_element_size
branch
from
db7cd95 to
49b52f9
Compare
ibhati
reviewed
Oct 2, 2025
| svs::data::SimpleData<float, svs::Dynamic>(50, 20); // Different size, same dims | ||
| CATCH_REQUIRE(data1.element_size() == data2.element_size()); | ||
| } | ||
| } |
There was a problem hiding this comment.
This test looks good. Maybe we can add a similar test for SQDataset here
Also would be great to add a few more supported datatypes to ensure there is not discrepancy.
Comment on lines
+104
to
+105
| auto data2 = | ||
| svs::data::SimpleData<float, svs::Dynamic>(50, 20); // Different size, same dims |
There was a problem hiding this comment.
Suggested change
| auto data2 = | |
| svs::data::SimpleData<float, svs::Dynamic>(50, 20); // Different size, same dims | |
| // Different size, same dims | |
| auto data2 = | |
| svs::data::SimpleData<float, svs::Dynamic>(50, 20); |
| /// Return the number of dimensions for each entry in the dataset. | ||
| size_t dimensions() const { return getsize<1>(data_); } | ||
|
|
||
| /// Return The size in bytes of one vector: sizeof(element_type) * dimensions() |
There was a problem hiding this comment.
Suggested change
| /// Return The size in bytes of one vector: sizeof(element_type) * dimensions() | |
| /// Return the size in bytes of one vector: sizeof(element_type) * dimensions() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-to issue #104