3.18.0 spec update #65
Draft
+18,047
−635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
reviewed
Aug 15, 2024
| member x.DocumentSelector = x.DocumentSelector | ||
|
|
||
| type RegistrationParams = { Registrations: Registration[] } | ||
| type UnregistrationParams = { Unregisterations: Unregistration[] } |
There was a problem hiding this comment.
typo in the metamodel here maybe? Unregisterations isn't a word, Unregistrations would be (ish).
There was a problem hiding this comment.
// This should correctly be named `unregistrations`. However, changing this
// is a breaking change and needs to wait until we deliver a 4.x version
// of the specification.
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#unregistrationParams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Just showing the changes to the 3.18.0 spec. No real action here yet until it's really released.
WHY
HOW
copilot:walkthrough