Removes unused 'relevant_link_name' parameter in nutpour and exhaust pipe envs #3651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
peterd-NV
approved these changes
Oct 8, 2025
Mayankm96
approved these changes
Oct 9, 2025
Mayankm96
changed the title
hougantc-nvda
pushed a commit
to hougantc-nvda/IsaacLab
that referenced
this pull request
Nov 10, 2025
…pipe envs (isaac-sim#3651) # Description Parameter 'relevant_link_name' to nutpour and exhaust pipe mimic environments was mistakenly added in the Isaac Lab 2.3 PRs and this is causing an error. This PR removes them. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
hougantc-nvda
pushed a commit
to hougantc-nvda/IsaacLab
that referenced
this pull request
Nov 10, 2025
…pipe envs (isaac-sim#3651) # Description Parameter 'relevant_link_name' to nutpour and exhaust pipe mimic environments was mistakenly added in the Isaac Lab 2.3 PRs and this is causing an error. This PR removes them. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parameter 'relevant_link_name' to nutpour and exhaust pipe mimic environments was mistakenly added in the Isaac Lab 2.3 PRs and this is causing an error. This PR removes them.
Fixes # (issue)
[Isaac-Sim 5.1 rc14][Isaac-Lab 2.3] task_done_nut_pour() got an unexpected keyword argument 'relevant_link_name' https://nvbugspro.nvidia.com/bug/5566828
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there