Refactor source-analyze to filter by syntax paths instead of line ranges #758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax currently filters syntax objects during analysis by checking if their source locations fall within requested line ranges. As more of the codebase has moved to work with syntax paths, this line-based filtering has become a bottleneck.
Changes
Added
source-syntax-pathsfunction (private/source.rkt): Accepts asource?and optionalrange-set?of line numbers, returns asorted-set?ofsyntax-path?values for all syntax objects that overlap with the specified lines.Updated
source-analyzesignature (private/analysis.rkt): Changed from#:lines range-set?parameter to#:paths sorted-set?. The function now filters visited syntax objects by checking path membership instead of computing line overlaps during expansion observation.Updated call sites (
main.rkt): Convert line ranges to syntax paths viasource-syntax-pathsbefore passing tosource-analyze.Example
This enables expansion analyzers to work directly with syntax paths, making it straightforward to limit analysis to specific subtrees of the expanded syntax.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.