Skip to content

SR6PCB dev #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: Development
Choose a base branch
from
Draft

SR6PCB dev #23

wants to merge 4 commits into from

Conversation

@millibyte-products
Copy link
Contributor

@millibyte-products millibyte-products commented Apr 10, 2025

  • Adds support for SR6PCB
  • Cleans up some whitespace
  • Adds platformio build target (for SR6PCB prototype)

@millibyte-products millibyte-products marked this pull request as draft April 16, 2025 13:32
@jcfain
Copy link
Owner

jcfain commented Apr 16, 2025 •
edited
Loading

Uh oh, I missed this....sorry about the conflicts.

@millibyte-products
Copy link
Contributor Author

millibyte-products commented Apr 16, 2025

Nah, it's a draft/moving target!
But early reviews are always a good thing. If I'm totally going the wrong direction, let me know.

jcfain
jcfain reviewed Apr 16, 2025
View reviewed changes
ESP32/lib/pinDefaultsWROOM32.h
// Common PWM
#define VALVE_SERVO_PIN_DEFAULT 25
#define VALVE_SERVO_CHANNEL_DEFAULT (int8_t)ESPTimerChannelNum::HIGH3_CH6
#define TWIST_SERVO_PIN_DEFAULT 27
Copy link
Owner

@jcfain jcfain Apr 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to change the pins for the default ESP32? This is usually the devkit V1. I believe these should be overridden in the extended board class instead of changing the defaults.

jcfain
jcfain reviewed Apr 16, 2025
View reviewed changes
ESP32/platformio.ini
Copy link
Owner

@jcfain jcfain Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these comment deletions are ok I think, but allot are notes I've left to future me. Id like allot of them to stay. Ill clean them up eventually...probably.

jcfain
jcfain reviewed Apr 16, 2025
View reviewed changes
@jcfain
Copy link
Owner

jcfain commented Apr 16, 2025

Nah, it's a draft/moving target! But early reviews are always a good thing. If I'm totally going the wrong direction, let me know.

Ok cool, looks like the conflicts are mostly white space conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfain jcfain jcfain left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@millibyte-products @jcfain