Skip to content

Improve performance of hosting static files #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improve performance of hosting static files #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b27c79
Log a warning if the Content-type can't be set
jonathansick Sep 12, 2023
d6022c2
temp: print out the headers from the server stream
jonathansick Sep 12, 2023
a469f18
Populate server response with full set of headers
jonathansick Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ltdproxy/handlers/external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,10 @@ async def get_s3(
logger.debug("is png")
response_headers["Content-type"] = "image/png"
else:
logger.debug("did not change response content-type")
logger.warning(
"Did not change response content-type",
response_headers=response_headers,
)

logger.debug("response headers", headers=response_headers)

Expand Down
6 changes: 1 addition & 5 deletions src/ltdproxy/rewrites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,7 @@ async def build_response(self, path: str) -> Optional[StreamingResponse]:
return None

stream_headers = stream.headers
response_headers = {}
copy_headers = ("Content-Type", "Content-length")
for key in copy_headers:
if key in stream_headers:
response_headers[key] = stream_headers[key]
response_headers = dict(stream_headers)

return StreamingResponse(
stream.aiter_raw(),
Expand Down