added allowFlip flag to GuillotineBinPack #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
reviewed
Sep 24, 2019
| @@ -1,5 +1,5 @@ | |||
| /** @file GuillotineBinPack.cpp | |||
| @author Jukka Jylänki | |||
| @author Jukka Jyl�nki | |||
There was a problem hiding this comment.
Can you check to avoid garbling the UTF-8 encoding on the files?
juj
reviewed
Sep 24, 2019
GuillotineBinPack.cpp
Outdated
| { | ||
| binWidth = width; | ||
| binHeight = height; | ||
| binAllowFlip = allowFlip; |
There was a problem hiding this comment.
I think the original files used tabs as indentation, though this new code uses spaces, causing a mismatch in indentation above.
|
Thanks, looks like a good feature - some formatting quirks though? |
added 2 commits
September 25, 2019 12:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.