Skip to content

Conversation

@blegat blegat marked this pull request as ready for review May 14, 2024 10:09
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 85.47009% with 68 lines in your changes missing coverage. Please review.

Project coverage is 80.06%. Comparing base (c4f7e9a) to head (66e8e51).
Report is 12 commits behind head on master.

Files Patch % Lines
src/Certificate/newton_polytope.jl 90.28% 17 Missing ⚠️
src/constraints.jl 75.00% 8 Missing ⚠️
src/Bridges/Constraint/sos_polynomial.jl 84.09% 7 Missing ⚠️
src/Certificate/Symmetry/wedderburn.jl 0.00% 6 Missing ⚠️
.../Constraint/sos_polynomial_in_semialgebraic_set.jl 68.75% 5 Missing ⚠️
src/Certificate/ideal.jl 91.83% 4 Missing ⚠️
src/attributes.jl 60.00% 4 Missing ⚠️
src/Bridges/Bridges.jl 40.00% 3 Missing ⚠️
src/Certificate/Certificate.jl 82.35% 3 Missing ⚠️
src/sosdec.jl 89.65% 3 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (c4f7e9a) and HEAD (66e8e51). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c4f7e9a) HEAD (66e8e51)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   85.10%   80.06%   -5.04%     
==========================================
  Files          41       38       -3     
  Lines        2222     2162      -60     
==========================================
- Hits         1891     1731     -160     
- Misses        331      431     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blegat blegat mentioned this pull request Jul 3, 2024
@blegat blegat merged commit b9a03eb into master Jul 4, 2024
@blegat blegat deleted the bl/use_kernel branch July 4, 2024 10:08
@kalmarek
Copy link
Contributor

kalmarek commented Jul 4, 2024

Holy crap! all those fixes will make SOS great again! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants